diff options
| author | Gabriel Wicki <gabriel@erlikon.ch> | 2024-12-02 23:38:51 +0100 |
|---|---|---|
| committer | Ludovic Courtès <ludo@gnu.org> | 2024-12-12 12:52:07 +0100 |
| commit | 27b4c319c06d1bc1dd8a79d225c1e0d90c9b667d (patch) | |
| tree | 77e37c2ca82936cf363c9e71f9496c85b08bc57b | |
| parent | 687f4e22e666aa06dfac7344ff652fb51e47a4b0 (diff) | |
lint: Prevent false positives in description typo check.
* guix/lint.scm(check-description-style)[check-description-typo]: Add spaces
to match strings to prevent matching false positives, like "allows tokens" or
"prevents torpedoes".
* tests/lint.scm: Add test.
Change-Id: Ifc2ec6167a590b9d2e742dd86fecd798c4bfaa24
Signed-off-by: Ludovic Courtès <ludo@gnu.org>
| -rw-r--r-- | guix/lint.scm | 4 | ||||
| -rw-r--r-- | tests/lint.scm | 8 |
2 files changed, 9 insertions, 3 deletions
diff --git a/guix/lint.scm b/guix/lint.scm index 396ee01fed..ee2059d812 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -507,8 +507,8 @@ by two spaces; possible infraction~p at ~{~a~^, ~}") (check-trademarks description) (check-description-typo description '(("This packages" . "This package") ("This modules" . "This module") - ("allows to" . #f) - ("permits to" . #f))) + ("allows to " . #f) + ("permits to " . #f))) ;; Use raw description for this because Texinfo rendering ;; automatically fixes end of sentence space. (check-end-of-sentence-space description) diff --git a/tests/lint.scm b/tests/lint.scm index 6631034151..47e31a69bf 100644 --- a/tests/lint.scm +++ b/tests/lint.scm @@ -219,12 +219,18 @@ (check-description-style pkg)))) (test-equal "description: grammar 'allows to'" - "description contains typo 'allows to'" + "description contains typo 'allows to '" (single-lint-warning-message (let ((pkg (dummy-package "x" (description "This package allows to do stuff.")))) (check-description-style pkg)))) +(test-equal "description: grammar 'allows to' 2" + '() + (let ((pkg (dummy-package "x" + (description "This package allows tokenization.")))) + (check-description-style pkg))) + (test-equal "synopsis: not a string" "invalid synopsis: #f" (single-lint-warning-message |